search

snowplow / snowplow-javascript-tracker

Snowplow event tracker for client-side and server-side JavaScript. Add analytics to your websites, web apps and servers.
http://snowplowanalytics.com
BSD 3-Clause "New" or "Revised" License
547 stars 220 forks source link

Document the fact that PRs from users outside the Snowplow organization will fail travis #616

Closed chrissherlock closed 4 years ago

chrissherlock commented 7 years ago

All recent Travis builds have been failing with the following:

Running "intern:functional" (intern) task
Listening on 0.0.0.0:9000
Error: Tunnel failed to start: Exit code: 1
  at handleChildExit  <node_modules/digdug/Tunnel.js:336:16>
  at Socket.<anonymous>  <node_modules/digdug/Tunnel.js:379:6>
  at emitOne  <events.js:82:20>
  at Socket.emit  <events.js:169:7>
  at Pipe._onclose  <net.js:469:12>
Warning: Test failure; check output above for details. Use --force to continue.
Aborted due to warnings.
The command "grunt travis" exited with 3.
BenFradet commented 7 years ago

The CI is very fiddly, but I don't think it fails every time.

chrissherlock commented 7 years ago

I could be wrong, but all the pull requests have failed so far :(

chuwy commented 7 years ago

That's fine @chrissherlock. Our CI/CD works properly only on PR pushed by us. I don't see how this can prevent PRs to be merged.

chrissherlock commented 7 years ago

Thanks, can you perhaps make this a bit more clear somewhere though?

Sent from my iPhone

On 20 Oct 2017, at 1:18 am, Anton Parkhomenko notifications@github.com wrote:

That's fine @chrissherlock. Our CI/CD works properly only on PR pushed by us. I don't see how this can prevent PRs to be merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

BenFradet commented 7 years ago

That's a great point, adjusting the ticket's name to reflect that.

paulboocock commented 4 years ago

Duplicate of #606