search

snowplow / snowplow-php-tracker

Snowplow event tracker for PHP. Add analytics into your PHP apps and scripts
http://snowplowanalytics.com
34 stars 36 forks source link

Release/0.4.1 #100

Closed greg-el closed 2 years ago

greg-el commented 2 years ago
coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.07%) to 89.013% when pulling bb3fc1dbdd6aae903a5807b23c60fa26fb3147c5 on Release/0.4.1 into 530ba8f8d76ade19cb6ce4cbd996df6c2fbc62b6 on master.

paulboocock commented 2 years ago

After reading the comments from @matus-tomlein a couple of other things come to mind:

matus-tomlein commented 2 years ago

Found out that there were 2 problems with the docker-compose build:

  1. The Dockerfile checks hash for composer script that it downloads over the internet. The script has changed and so its hash changed too. I updated the hash and created a tiny PR for it
  2. The second problem with building the tracker and running tests happens only on ARM Macs (typical). Some of the dependencies do not support ARM Macs and need to be bumped. I managed to get it to work, but I don't think this is something that we need to add to this release. We can hold onto it a bit more since it also requires updating the PHP version.

So my suggestion for this release is that we:

  1. fix the commit names in this release PR (as explained above), and
  2. merge the small PR with updated composer hash.
paulboocock commented 2 years ago

I think we can include the dependency bumps here as we should be going to 0.5.0 anyway. It's always a good idea to take the opportunity of updating a tracker to bump the dependencies.

AlexBenny commented 2 years ago

Jumping in only with a quick note about the workflow. We set the guidelines here for external contributions and publishing: https://snplow.atlassian.net/wiki/spaces/DVR/pages/2775121921/Tracker+contribution#When-we-import-a-PR-of-an-external-contributor I think that should be the reference for all the trackers, if it doesn't suit some cases we can always edit it. The section about contribution is completely new so I'm not sure it works 100%, we can always discuss it and change it if there are problems.

greg-el commented 2 years ago

Superseded by https://github.com/snowplow/snowplow-php-tracker/pull/112