snowplow / snowplow-php-tracker

Snowplow event tracker for PHP. Add analytics into your PHP apps and scripts
http://snowplowanalytics.com
34 stars 36 forks source link

Add a default timeout to curl and a custom log dir #122

Closed dbhynds closed 1 year ago

dbhynds commented 1 year ago

We've been using a fork of this package for a while. I figured it's worth opening up a PR for the changes. This PR:

For the timeout, we had issues where the service being called by the CurlEmitter was experiencing high latency. This is a resiliency measure that allows us to terminate slow requests and avoid high latency in another system from causing latency issues in our application.

snowplowcla commented 1 year ago

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

dbhynds commented 1 year ago

I signed it!

snowplowcla commented 1 year ago

Confirmed! @dbhynds has signed the Contributor License Agreement. Thanks so much.

matus-tomlein commented 1 year ago

Thanks for the contribution @dbhynds! It looks good, but I would like to make a small change to keep the default timeout for curl while making it configurable.

I will cherry pick your commit and make the changes. Thanks again for the PR!