search

snowplow / snowplow-php-tracker

Snowplow event tracker for PHP. Add analytics into your PHP apps and scripts
http://snowplowanalytics.com
34 stars 36 forks source link

Fixed reference to object #136

Closed florisluiten closed 1 year ago

florisluiten commented 1 year ago

The object referenced in the PHP doc is lowercased, but the actual class is camelCased. By using the same casing, we ensure that the IDE and any static analyzer understands the reference.

snowplowcla commented 1 year ago

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

florisluiten commented 1 year ago

I'm happy to help, but I'm not comfortable singing the Contributor License Agreement. Especially since my fix is just one character.

Feel free to ignore my pull request. Perhaps you stumble on the same issue yourself, and find a solution for it.

adatzer commented 1 year ago

Hello @florisluiten and thank you for your contribution! Even if this pull request is closed, please feel free to open a GitHub issue instead, so that we can look to address this in a next release. If you want to do so, could you please add some more information on what the difference is between the expected and actual behaviour?

florisluiten commented 1 year ago

Thanks, I've created an issue: https://github.com/snowplow/snowplow-php-tracker/issues/137