search

snowplow / snowplow-php-tracker

Snowplow event tracker for PHP. Add analytics into your PHP apps and scripts
http://snowplowanalytics.com
34 stars 36 forks source link

Generate a true uuid for events #41

Closed mlively closed 9 years ago

mlively commented 9 years ago

Attempts to use the uuid extension if it exists. If it does not it falls back to a php uuid library. This does introduce a new required dependency. This resolves issue #39.

Also, if the build fails in the curl emitter that is likely due to: https://github.com/snowplow/snowplow-php-tracker/pull/40

I figured it made sense to keep the PRs separate as you guys may want to go a different direction with UUIDs.

The dependency involved can be found at: https://github.com/ramsey/uuid

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.08%) to 87.79% when pulling b70c7e071505506590b608c9ffc8ee4f42ddbb40 on mlively:snowplow-#39 into 68a17e87a0125ffdc837887bfcb60232cde31b63 on snowplow:master.

alexanderdean commented 9 years ago

Thanks @mlively! This approach sounds sensible to me - @jbeemster any thoughts?