Allow page URL to be set on the Subject

snowplow / snowplow-php-tracker

Snowplow event tracker for PHP. Add analytics into your PHP apps and scripts

http://snowplowanalytics.com

34 stars 36 forks source link

Allow page URL to be set on the Subject #47

Closed smugmug-api-docs closed 5 years ago

alexanderdean commented 9 years ago

Many thanks! Have you signed our CLA? https://github.com/snowplow/snowplow/wiki/CLA

coveralls commented 9 years ago

Coverage decreased (-0.26%) to 87.54% when pulling 131871e7d6717b52d11d4887b7ddda325adfe625 on smugkarl:subject-page-url into cff73c3ebfcbaf10c5323e1eb071beb8ae9450fb on snowplow:master.

coveralls commented 9 years ago

Coverage decreased (-0.26%) to 87.54% when pulling 131871e7d6717b52d11d4887b7ddda325adfe625 on smugkarl:subject-page-url into cff73c3ebfcbaf10c5323e1eb071beb8ae9450fb on snowplow:master.

smugmug-api-docs commented 9 years ago

The CLA has now been signed by SmugMug (for which I made this change).

alexanderdean commented 9 years ago

Hi @smugkarl - I just checked the entry. It looks good but alas the GitHub account names are wrong - the contributors are listed as having smugmug as your username, instead of smugkarl etc. Can you ask your Controller to fix?

smugmug-api-docs commented 9 years ago

Unfortunately, he just went on vacation.

oguzhanunlu commented 5 years ago

Closing as this is already introduced within #75 .