snowplow / snowplow-php-tracker

Snowplow event tracker for PHP. Add analytics into your PHP apps and scripts

http://snowplowanalytics.com

34 stars 36 forks source link

Update to PHP 7.2 + Vendors #72

Closed albert-gonzalez closed 5 years ago

albert-gonzalez commented 5 years ago

Hi!

In order to have the dependencies of our project updated, we have forked your library and updated it. It seems that you don't maintain this repo anymore, but it would be interesting if you generated a new version with these changes.

PHP 7.2 is required because older versions are not maintained anymore. More info: https://www.php.net/supported-versions.php

Changes

Docker + docker-compose configured
Script to execute tests in docker
Vendors updated
- PHPUnit 8.1
- UUID 3.8
- rmccue/requests 1.7
- php-coveralls 2.1
PHP 7.2 Required

snowplowcla commented 5 years ago

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

albert-gonzalez commented 5 years ago

I signed it!

snowplowcla commented 5 years ago

@albert-gonzalez has signed the Software Grant and Corporate Contributor License Agreement

BenFradet commented 5 years ago

@mhadam @oguzhanunlu could you have a look? thanks.

albert-gonzalez commented 5 years ago

Hi!

If I have to do something else, please tell me :)

oguzhanunlu commented 5 years ago

Looks good to me! Thanks @albert-gonzalez !

oguzhanunlu commented 5 years ago

Closing the PR since we incorporated the work into #75 . Thanks again @albert-gonzalez , your contribution is cherry-picked into the release branch.

albert-gonzalez commented 5 years ago

Glad to hear it! Thanks for your great work!