search

snowplow / snowplow-php-tracker

Snowplow event tracker for PHP. Add analytics into your PHP apps and scripts
http://snowplowanalytics.com
34 stars 36 forks source link

Remove deprecated $errcontext from custom error handler #80

Closed angsmugmug closed 3 years ago

angsmugmug commented 5 years ago

$errcontext is an optional parameter deprecated on custom error handlers as of PHP 7.2.0

It is also unused in Constants::warning_handler()

snowplowcla commented 5 years ago

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

angsmugmug commented 5 years ago

I signed it!

On Tue, Jul 2, 2019 at 8:49 AM Snowplow CLA bot notifications@github.com wrote:

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/snowplow/snowplow-php-tracker/pull/80?email_source=notifications&email_token=ABXVDBXQ7XGA6BPUYP7O5JDP5N2GZA5CNFSM4H45HOUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZBW5VA#issuecomment-507735764, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXVDBTGEHVHVFYNJTR5XPLP5N2GZANCNFSM4H45HOUA .

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 88.138% when pulling f2edd0db2f5a9605ea454ce9993b85f9b27ad406 on angsmugmug:patch-1 into bcc0564ff7cefd408aef5f828ff7693e5f32e580 on snowplow:master.

snowplowcla commented 5 years ago

Confirmed! @angsmugmug has signed the Individual Contributor License Agreement. Thanks so much

adatzer commented 3 years ago

Thank you @angsmugmug ! Included in #96 . Closing.