search

snowplow / snowplow-php-tracker

Snowplow event tracker for PHP. Add analytics into your PHP apps and scripts
http://snowplowanalytics.com
34 stars 36 forks source link

Allow tracking with the session ID #82

Closed henriquemoody closed 3 years ago

henriquemoody commented 4 years ago

The "sid" parameter that maps to the "domain_sessionid" 1 field is present across different event types, as "domain_sessionid" is a common field regardless of the event or platform 2.

This commit introduces the ability to define the session-id by the "Subject" object.

snowplowcla commented 4 years ago

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://github.com/snowplow/snowplow/wiki/CLA to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.04%) to 88.177% when pulling bc8095f95e7337cf0490c85a8224e583dd9e18f8 on henriquemoody:domain_sessionid into bcc0564ff7cefd408aef5f828ff7693e5f32e580 on snowplow:master.

adatzer commented 3 years ago

Hello @henriquemoody! Thank you very much for this pull request! In fact, we'd like to include your contribution to version 0.4.0 of the snowplow-php-tracker. Would you consider signing the Contributor License Agreement?

henriquemoody commented 3 years ago

I wouldn't like to do that, because I'd need to give you data I'm not willing to give.

I think it would be great if you change this policy, it makes contributing to this project really hard.

I'm closing this pull request, but I won't make a fuss if you make the exact same implementation I did, but I won't be signing anything.

goodits commented 3 years ago

Hi @henriquemoody, first of all apologies for the initial delay on the PR.

I think it would be great if you change this policy

I'm happy to look in to it. This information is under lock and key. Only access is to keep things moving if the bot misbehaves. However I understand your concern - data privacy is after all one of the reasons we're here. I'll check in with our legal to see what we really need here and can put any rework in to upcoming plans we have for improving our OS community and estate.

If you have any other feedback, do reach out.