search

snowplow / snowplow-php-tracker

Snowplow event tracker for PHP. Add analytics into your PHP apps and scripts
http://snowplowanalytics.com
34 stars 36 forks source link

Allow log dir to be overridden for FileEmitter #99

Closed EricTendian closed 2 years ago

EricTendian commented 2 years ago

This allows the $log_dir value to be set differently than just wherever the library is installed, for environments where the vendor directory is not writeable. When constructing the FileEmitter, a user can now specify some other directory like /tmp/ for the various event and worker subdirectories to be created.

I've added a test to prove the logic works.

snowplowcla commented 2 years ago

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

EricTendian commented 2 years ago

@snowplowcla I signed it.

snowplowcla commented 2 years ago

Confirmed! @EricTendian has signed the Contributor License Agreement. Thanks so much.

paulboocock commented 2 years ago

Thanks for the contribution. We have a PHP Tracker release tentatively planned for December. So, pending testing and approval, we will look to include this PR in that release.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 88.942% when pulling 7892dca56f494dfcbd6acfdb7e19e74e1293bd97 on EricTendian:master into 530ba8f8d76ade19cb6ce4cbd996df6c2fbc62b6 on snowplow:master.