search

snowplow / snowplow-scala-analytics-sdk

Scala SDK for working with Snowplow enriched events in Spark, AWS Lambda, Flink et al.
https://snowplow.github.io/snowplow-scala-analytics-sdk/
20 stars 14 forks source link

Fix specification assuming unstruct_event field contains contexts envelope #57

Closed chuwy closed 6 years ago

chuwy commented 6 years ago

https://github.com/snowplow/snowplow-scala-analytics-sdk/blob/master/src/test/scala/com.snowplowanalytics.snowplow.analytics.scalasdk.json/EventTransformerSpec.scala#L34

It shouldn't introduce any bugs in tests, just makes specification slightly confusing. Envelope should be unstruct_event

alexanderdean commented 6 years ago

How does that test pass?

chuwy commented 6 years ago

Algorithm does not know about proper schema name.