search

snowplow / snowplow-scala-tracker

Snowplow event tracker for Scala. Add analytics to your Scala, Akka and Play apps and servers
http://snowplowanalytics.com
8 stars 14 forks source link

Fix MiMa setup #174

Open oguzhanunlu opened 2 years ago

oguzhanunlu commented 2 years ago

It seems like bin compat isn't checked as expected, I see the following output in deploy workflow's related step

[info] set current project to root (in build file:/home/runner/work/***-scala-tracker/***-scala-tracker/)
[info] root: mimaPreviousArtifacts not set, not analyzing binary compatibility
[info] ***-scala-tracker-core: mimaPreviousArtifacts is empty, not analyzing binary compatibility.
[info] ***-scala-tracker-metadata: mimaPreviousArtifacts is empty, not analyzing binary compatibility.
[info] ***-scala-tracker-emitter-id: mimaPreviousArtifacts is empty, not analyzing binary compatibility.
[info] ***-scala-tracker-emitter-http4s: mimaPreviousArtifacts is empty, not analyzing binary compatibility.
andreamarcolin commented 2 years ago

I think this is a consequence of me removing 1.0.0 from the versions to check for compatibility ahead of 2.0.0 release (which is breaking and expected to be). I think the solution is to just add 2.0.0 (and future versions) to mimaPreviousArtifacts after 2.0.0 gets released