search

snowplow / snowplow-unity-tracker

Snowplow event tracker for Unity. Add analytics to your Unity games and apps
http://snowplowanalytics.com
Apache License 2.0
16 stars 11 forks source link

Fix race condition in the emit loop #8

Closed dbuscaglia closed 5 years ago

dbuscaglia commented 5 years ago

The consume loop can race on grabbing sqllite.

We have other updates around the sqllite version and bringing this current

dbuscaglia commented 5 years ago

Signed the contributor agreement.

snowplowcla commented 5 years ago

@dbuscaglia has signed the Software Grant and Corporate Contributor License Agreement

dbuscaglia commented 5 years ago

@BenFradet found one more.

BenFradet commented 5 years ago

@mhadam could you have a look? thanks.

dbuscaglia commented 5 years ago

@mhadam I have addressed your review.

dbuscaglia commented 5 years ago

Also, this is just one of two PRs we will be submitting. The other one will bring the tracker compatible with current unity versions.

mhadam commented 5 years ago

Awesome, I'll release this now. Thanks for the contributions!

mhadam commented 5 years ago

On second thought, I'll wait on you to make the other PR, if that's ok. I've started staging the release in develop.

dbuscaglia commented 5 years ago

@mhadam ok it won't be for a bit, because I want our engineer who did the sqllite and session changes to make the PR.