search

snowplow / snowplowanalytics.com

The Snowplow website
https://snowplowanalytics.com
12 stars 19 forks source link

Blog post on breaking up the mono repo #1344

Closed goodits closed 4 years ago

goodits commented 4 years ago

Comments welcome.

@chuwy I've made some updates since you reviewed the Google doc.

@nepsil0n I think I've added everything I need to - please confirm if you get a second. I haven't spun the site up locally, but will check it thoroughly on next. Let me know if that's not the process.

goodits commented 4 years ago

@nepsil0n I cut from master, and raised the PR again next. That's correct, isn't it? It seems to have picked up some commits from master that weren't merged in to next?

nepsil0n commented 4 years ago

Hey @goodits, everything seems to be fine from a first view. I will merge in next and check it out. Also regarding some commits, it might be possible that I had 1-2 commits that were done directly on master during my WP investigation period so that I can reach with everything. I will double check this to confirm but I usually follow up with merge master to next afterwards. The process is correct, pull request should be always on next.

Thanks!