search

snowplow / sql-runner

Run templatable playbooks of SQL scripts in series and parallel on Redshift, PostgreSQL, BigQuery and Snowflake
http://snowplowanalytics.com
Apache License 2.0
79 stars 14 forks source link

Surface error message for incorrect passwords #182

Closed colmsnowplow closed 2 years ago

colmsnowplow commented 3 years ago

Sometimes we will throw WARNING: No queries to run rather than a connection error for incorrect or missing password. SQL-runner should return clearer error messages for each error case.

adatzer commented 2 years ago

The cause was because of the missing error handling from fillTemplates and could be reproduced by any value in playbook that may trigger that error, e.g. :password: {{notSupportedSecretFunc "X"}}. It was being mostly surfaced for passwords, as this is where template functions are usually used.

Was fixed in v0.10.0 as part of https://github.com/snowplow/sql-runner/commit/6cf2e12ef7a5cc06b5af747c96cb29f0e682fba3 Closing.