snowstopxt / pe

0 stars 0 forks source link

Email bug rejected a valid email address #5

Open snowstopxt opened 5 days ago

snowstopxt commented 5 days ago

The email field restricted this valid email according to the email requirements.

image.png

nus-pe-bot commented 1 day ago

Team's Response

Duplicate as #2815, this is a documentation bug.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incomplete error message for invalid email addresses

The error message when adding, editing to an email address that is invalid is incomplete, the error states that:

Emails should be of the format local-part@domain and adhere to the following constraints:
1. The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). The local-part may not start or end with any special characters.
2. This is followed by a '@' and then a domain name. The domain name is made up of domain labels separated by periods.
The domain name must:
   - end with a domain label at least 2 characters long
   - have each domain label start and end with alphanumeric characters
   - have each domain label consist of alphanumeric characters, separated only by hyphens,if any.

However, it does not pick up the issue on having two consecutive _ in the email local-part, to fix this, we can complete the error message by adding 3. Local-part should not have consecutive special characters or updating the User Guide for the domain constraints.

For replication purposes: add n/Jollibee p/92929292 e/jo____llibee@yahoo.com a/NUS U-Town cp/ r/

Screenshot 2024-11-15 170539.png


[original: nus-cs2103-AY2425S1/pe-interim#3846] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We agree that we overlooked this issue and did not mention it in the application or the UG. Hence, this is a documentation bug that we have missed out.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** I disagree with this as it is a bug related to system testing where it is testing invalid inputs for the email validator. There is inherently nothing wrong with the documentation, but the error stems from somewhere in the code. ![image.png](https://raw.githubusercontent.com/snowstopxt/pe/main/files/362b29a5-93fc-4847-8577-d9185140861b.png)
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]