search

snoww / loa-logs

LOA Logs - Modern DPS Meter for Lost Ark
GNU General Public License v3.0
128 stars 30 forks source link

Raid gate names #47

Closed x-OvO-x closed 8 months ago

x-OvO-x commented 8 months ago

Adds the gate of the raid that the boss belongs to if the information is available and the user toggled the setting to display it. I'm still somewhat new to svelte might not have used the correct practices but let me know!

Past encounters list firefox_KtJzF82oWs

Inside the encounter firefox_i5wi2f006J

It also adds it to the screenshots

snoww commented 8 months ago

hi thanks for the pr, everything looks pretty good to me, ill pull it and test it out when i get the chance. not sure about the color choice, need other some opinions also missing the setting in src-tauri/src/parser/models.rs - GeneralSettings (this is used to save the settings to a file)

x-OvO-x commented 8 months ago

Sorry about that, couldn't get that part tested since i never wrote rust and couldn't figure out how to get it started without the meter-core D: Should have mentioned that, hope the latest commit is enough. I was also not too sure about the color so definitely up to have it changed!

snoww commented 8 months ago

thanks. if you want to pull meter-core-rs feel free to dm me on disc and i can give you access