snoww / loa-logs

LOA Logs - Modern DPS Meter for Lost Ark
GNU General Public License v3.0
128 stars 30 forks source link

Add player gear score even when names are enabled #5

Closed elfungi closed 1 year ago

elfungi commented 1 year ago
snoww commented 1 year ago

hi, thanks for the pr prolly a better idea to add an option in settings to enable gear score or not that way people can choose themselves

if you're unsure on how to do that don't worry about it, i can add it next patch as i'm currently in the process of rewriting the sniffer in rust.

elfungi commented 1 year ago

hi, thanks for the pr prolly a better idea to add an option in settings to enable gear score or not that way people can choose themselves

if you're unsure on how to do that don't worry about it, i can add it next patch as i'm currently in the process of rewriting the sniffer in rust.

I had a go at it - let me know if I missed anything for the setting.

snoww commented 1 year ago

I think u got everything except here, it is pretty hidden https://github.com/snoww/loa-logs/blob/d7293d71389d2f16463c81d8add8ed044516705a/src-tauri/src/parser/models.rs#L399-L408 otherwise looks good to me

snoww commented 1 year ago

just a nit pick, i think it should be off by default

elfungi commented 1 year ago

just a nit pick, i think it should be off by default

Done! It's your project; nitpick all you like 😄