search

snoww / loa-logs

LOA Logs - Modern DPS Meter for Lost Ark
GNU General Public License v3.0
124 stars 24 forks source link

Added Optional Time To Kill Tracker in Live Meter Header #57

Closed JonasHri closed 5 months ago

JonasHri commented 5 months ago

image

It shows the time until the boss dies as if all alive players were to continue doing the same DPS. It's good to know if you are still on pace to clear before enrage. It does not factor in the loss of buffs if the support dies. The description in the Settings Menu might be subject to change if you do not like it.

JonasHri commented 5 months ago

I added the setting to model.rs and removed the unused import. how do I add those changes to this pull request, or do I have to open a new one?

snoww commented 5 months ago

I added the setting to model.rs and removed the unused import. how do I add those changes to this pull request, or do I have to open a new one?

you just need to make changes and push ur branch, which i see already

JonasHri commented 5 months ago

Ah okay, I was blind then. The prettier formatter does not undo the changes of the default one. It seems I need your prettier config so that it works.

snoww commented 5 months ago

also when meter window is too small, the text gets wrapped image

JonasHri commented 5 months ago

also when meter window is too small, the text gets wrapped image

This is a more complex issue as the collapsing of the buttons is currently hard coded by the number of pixels. image

When you have the Boss Icon as well as the TTK enabled this hard-coded value is a bit too low. For now, I can increase this hard-coded value by 5 px which will make it work for the normal meter scaling. (70 px is approximately the width of the ttk element at normal scale, But increasing the value by more than 5px seems to break a whole lot more.) The text wrapping is however still an issue if the meter scale is increased in the accessibility settings. On the largest scale, this wrapping occurs even when TTK is disabled.

Making this consistent will probably have to be a separate issue. It will either need a js function to check the div locations or a whole mess of if clauses.

snoww commented 5 months ago

i made a couple of changes to ur branch but i cannot push to it since it says i do not have permission

JonasHri commented 5 months ago

I sent you an invite to my fork. If you think the PR is finalized after those changes, it would be better to accept the pull into a branch, add your changes, and then merge the branch into master.