Adding onHit event for renderList items

[IanTyf]

Added capability for renderList items to have onHit callbacks. Can now treat these objects as buttons, or use the callback function to manipulate the object itself. Also supports grouping objects together, which would be helpful when having a complex object like a human figure or a desk.

Added a demo scene to show how it works.

https://user-images.githubusercontent.com/54942106/124706260-8d2b2400-df29-11eb-8aae-218d7a5def91.mp4

[snowymo]

Awesome work. I may need some to test if it works for multiuser when we synchronize all the input events via the server. For example, when user A is moving the controller to hit the object, what will user B see from the other side?

[IanTyf]

At the moment user B won't see any changes to the object that is hit by user A. I'm not exactly familiar with how inputs are synchronized here so it's not implemented yet. But I thought this could still be a useful tool for some of the demos, even though it's only local to the user.

[snowymo]

You mean user B can see user A's controller moves but no consequence of the hit?

[IanTyf]

I just made some changes and now the hit events should be synchronized correctly, aka user B will see the hit events when user A hits something. Mostly the change is to add an extra parameter for the input event handler functions since I need to know which user is performing the input action, in order to do hittesting/raytracing from the corresponding controller.

[snowymo]

Glad to know it is working. Can you put a video here?

Also, I quickly went through your changes. It seems now we know the id of the input event. So functions like OnPress has id as parameters. However, I don't know if ids is necessary. It seems to me that ids contains buttons states for each user. I remember we have buttonState recording that https://github.com/futurerealitylab/immersive-presentation/blob/hitTest/js/render/core/renderListScene.js#L19. Are they close?

[IanTyf]

Oh yes I forgot to change the variable name. ids is a terrible name for what it's representing. It contains button states for each user's controllers, but the state is simply "pressed", "dragged", or "released", as those would be sufficient for this situation, whereas I think buttonState holds the button state for EVERY button on the left and right controller of the local user, so it's like an array of true and false. In other words, ids is more similar to window.isPressed, window.isDragged, etc, but for every user.

I'll change the variable name and maybe restructure it a bit and push again, as well as put up a video once I got home!

[snowymo]

Nice. No rush. I probably will accept that next week since we are doing rehearsal this week.

On Wed, Jul 21, 2021 at 2:19 PM IanTyf @.***> wrote:

Oh yes I forgot to change the variable name. ids is a terrible name for what it's representing. It contains button states for each user's controllers, but the state is simply "pressed", "dragged", or "released", as those would be sufficient for this situation, whereas I think buttonState holds the button state for EVERY button on the left and right controller of the local user, so it's like an array of true and false. In other words, ids is more similar to window.isPressed, window.isDragged, etc, but for every user.

I'll change the variable name and maybe restructure it a bit and push again, as well as put up a video once I got home!

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/futurerealitylab/immersive-presentation/pull/33#issuecomment-883924093, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNLBKKTPG3A3UMQO5YTFELTYZRI7ANCNFSM4755SCIA .

-- Regards, Zhenyi

[IanTyf]

https://user-images.githubusercontent.com/54942106/127319583-4fe98463-58c6-4fba-9ef9-3101f2c801d8.mp4

[snowymo]

@IanTyf Would you mind resolving the conflicts so I can accept this PR?