search

snowyu / libtorrent

Automatically exported from code.google.com/p/libtorrent
Other
1 stars 0 forks source link

Diffie-Hellman secret calculation failure is mishandled #693

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The dh_key_exchange::compute_secret method returns 1 on failure, but the peer 
connection handshake assumes it returns -1 on failure.

// read dh key, generate shared secret
if (m_dh_key_exchange->compute_secret(recv_buffer.begin) == -1)
{
  disconnect(errors::no_memory);
  return;
}

Original issue reported on code.google.com by rmaudsley on 6 Nov 2014 at 4:11

GoogleCodeExporter commented 9 years ago 
Thanks! fixed in RC_0_16 and RC_1_0

Original comment by arvid.no...@gmail.com on 6 Nov 2014 at 5:53