search

snoyberg / classy-prelude

A typeclass-based Prelude.
108 stars 15 forks source link

The type of sum and product in ClassyPrelude #101

Open nanonaren opened 9 years ago

nanonaren commented 9 years ago

I am thinking that since we have osum and oproduct that work on mono-traversable types, I think the sum and product exported from ClassyPrelude should work on Foldable types -- as in, rather than being aliases for osum and oproduct, they should overwrite the non-strict sum and product implementations in Data.Foldable with strict versions. I feel this would make things more consistent with the re-exported Foldable module.

snoyberg commented 9 years ago

That's inconsistent with the rest of the module, which uses the unprefixed names for all MonoFoldable functions.