search

snoyberg / classy-prelude

A typeclass-based Prelude.
108 stars 15 forks source link

yesod: don't import yesod-newsfeed or persistent #92

Open gregwebs opened 9 years ago

gregwebs commented 9 years ago

Note the version bump here: that makes it no longer correspond to classy-prelude. This is now confusing because the library started off tracking versions.

This library now saves 6 lines over putting it directly into Import.hs, and users will have to dig a bit deeper to find out how things are getting imported.

snoyberg commented 9 years ago

I understand that Yesod.Feed introduces am extra dep, but how does the Sql import hurt anyone?

gregwebs commented 9 years ago

it adds a dependency on persistent

snoyberg commented 9 years ago

It doesn't, since yesod depends on persistent transitively already.

gregwebs commented 9 years ago

One way or another someone should be able to create a simple app scaffolding without a persistent dependency. This seems to be working against that even if it isn't the root of the issue.

gregwebs commented 9 years ago

I changed the yesod dep to yesod-core. This change would be a good preparation for the yesod-shakespeare split.