search

snoyberg / http-client

An HTTP client engine, intended as a base layer for more user-friendly packages.
281 stars 193 forks source link

httpSink Sink Depricated #411

Open BebeSparkelSparkel opened 5 years ago

BebeSparkelSparkel commented 5 years ago

https://hackage.haskell.org/package/conduit/docs/Data-Conduit.html#t:Sink

Deprecated: Use ConduitT directly

snoyberg commented 5 years ago

Please clarify what this means

BebeSparkelSparkel commented 5 years ago

httpSink uses Sink which is being deprecated

snoyberg commented 5 years ago

No, it's name includes Sink. Unless I'm misreading everything, it does not use the deprecated identifier. Can you please look again?

BebeSparkelSparkel commented 5 years ago

then httpSink docs should be updated http://hackage.haskell.org/package/http-conduit-2.3.7.1/docs/Network-HTTP-Simple.html#v:httpSink