search

snoyberg / markdown

Convert Markdown to HTML, with XSS protection
BSD 3-Clause "New" or "Revised" License
69 stars 401 forks source link

Monoid instance #7

Closed Tarrasch closed 12 years ago

Tarrasch commented 12 years ago

Hello, I'm just migrating to this from the Yesod.Markdown module by pbrisbin. I notice that this package doesn't provide any Monoid instance for the Markdown type. mappend should just use the mappend for the underlying type and then rewrap. Should I go ahead and implement this?

snoyberg commented 12 years ago

Seems like a good move to me, you could probably even get away with GeneralizedNewtypeDeriving.

Tarrasch commented 12 years ago

Oh, GeneralizedNewtypeDeriving, didn't think of that. :)

I was also thinking of adding the IsString instance too. What do you think?

snoyberg commented 12 years ago

Sounds fine to me, I see no harm.

Tarrasch commented 12 years ago

I added both instances in #8. So I'll close.