search

snoyberg / mime-mail

Compose MIME email messages.
41 stars 43 forks source link

Update to signature version 4. #61

Closed kindaro closed 4 years ago

kindaro commented 4 years ago

Resolve #60.

snoyberg commented 4 years ago

Thanks @kindaro!

@limick since you opened the original issue, would you be interested in reviewing before this is merged?

kindaro commented 4 years ago

@snoyberg  I added two small patches. If it is good for you, let me know and I shall squash.

snoyberg commented 4 years ago

LGTM. You interested in the Hackage maintainer bit?

kindaro commented 4 years ago

@snoyberg  I can try my hand at it, but I may still need an advice from time to time. If with this consideration in mind you are still willing to extend your offer, then surely I shall do my best to stand up to the responsibility.

snoyberg commented 4 years ago

Offer is definitely on the table still, and I'd be happy to provide guidance as necessary. You should also have an invite to be maintainer here. I'd say: merge here when ready, and if you give me your Hackage username I'll give you upload permissions.

jezen commented 4 years ago

This perhaps warrants a version bump for Hackage.

kindaro commented 4 years ago

@jezen  I am working on it. Expect in about 2 days.

jezen commented 4 years ago

@kindaro Understood. Thank you so much for your work on this! 👏