search

snoyberg / mono-traversable

Type classes for mapping, folding, and traversing monomorphic containers
153 stars 63 forks source link

`conduit-combinator` fails to build documentation due to inaccurate version bounds in `conduit` #116

Closed hvr closed 7 years ago

hvr commented 7 years ago

See

https://hackage.haskell.org/package/conduit-combinators-1.0.8.2/reports/

for details. NB: It's not Hackage's fault that the documentation could not be built.

snoyberg commented 7 years ago

Guess again https://github.com/snoyberg/conduit/issues/288. NB: PVP didn't prevent this.

hvr commented 7 years ago

NB: I didn't mention PVP at all

snoyberg commented 7 years ago

Never said you did. But you did say inaccurate version bounds. I also never said it was Hackage's fault that it didn't build.

hvr commented 7 years ago

Fair enough, I stand corrected. But since the PVP got mentioned, it was a result of failing to follow the PVP. Obviously the PVP can't prevent this unless it's actually been upheld by both parties to the contract. Fwiw, a similiar PVP violation just slipped into the Cabal 1.24.1.0 release which will likely have to be redacted asap

snoyberg commented 7 years ago

Given that there's no bug at all in conduit-combinators, can we close this issue?

hvr commented 7 years ago

sure

hvr commented 7 years ago

PS: Clearly, we need to polish the tooling to help detect cases where a version increment doesn't reflect the severity of the API changes. While it may not detect 100% cases, it would already help if it could point to potential problems.