Add 'asum' consumer - Githubissues

k0ral commented 7 years ago

Not satisfied with the name orA...

snoyberg commented 7 years ago

How about asum? And can I recommend as well:

Adding to the .Unqualified module with a C extension
Not sure about this: does it make sense to make an asumE for elements of the stream?

k0ral commented 7 years ago

Am I supposed to use gen-unqualified.hs script ? Because it looks as if it weren't used for some time:

I had to remove some end-of-lines in Combinators.hs to have it correctly parse signatures
the generated code significantly differs from the existing one from Unqualified.hs: missing functions are added, import list is different, haddock comments are changed, inline pragmas are added... it looks better actually.

Regarding asumE, I don't see the need to define it, mapC asum isn't that tiresome to type :) .

k0ral commented 7 years ago

Actually, the generated file doesn't build for various reasons unrelated to my change, so I'm manually adding asumC.

snoyberg commented 7 years ago

Thanks!

snoyberg / mono-traversable