snoyberg / mono-traversable

Type classes for mapping, folding, and traversing monomorphic containers
152 stars 63 forks source link

Add chunksOfE and chunksOfExactlyE #143

Closed luispedro closed 6 years ago

luispedro commented 6 years ago

chunksOfE and chunksOfExactlyE break the input sequences into chunks of a given size. If the input does not break into chunks of the given size, then 'chunksOfE' will yield a last chunk that is not of the requested size, while 'chunksOfExactlyE' will consider it a leftover element.

This was discussed as issue #142

luispedro commented 6 years ago

The travis failures seem completely unrelated to this PR.

snoyberg commented 6 years ago

There was one test case failure with GHC 7.8.4:

https://travis-ci.org/snoyberg/mono-traversable/jobs/308062721

Unfortunately cabal's display of the errors leaves out all of the useful information. Any thoughts on what could cause this?

luispedro commented 6 years ago

I have no idea what is happening. I tried to get the error locally, but I could not reproduce the environment on ghc 7.8.4....

snoyberg commented 6 years ago

I'm trying to clean up the Travis jobs, but it's slow going. Once I do that, I'll ping you and see if a rebase against master fixes the build.

On Wed, Nov 29, 2017 at 3:42 PM, Luis Pedro Coelho <notifications@github.com

wrote:

I have no idea what is happening. I tried to get the error locally, but I could not reproduce the environment on ghc 7.8.4....

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/snoyberg/mono-traversable/pull/143#issuecomment-347863693, or mute the thread https://github.com/notifications/unsubscribe-auth/AADBB57Rtu-qKo5MY40jf2H7RW30xL4Hks5s7V9bgaJpZM4Qqyft .

snoyberg commented 6 years ago

Thanks!