search

snoyberg / mono-traversable

Type classes for mapping, folding, and traversing monomorphic containers
152 stars 63 forks source link

Add mapNonNull #151

Closed cdepillabout closed 6 years ago

cdepillabout commented 6 years ago

This adds the mapNonNull function as discussed in #150.

snoyberg commented 6 years ago

Changes look good, but it seems like Travis has some trouble with the added checks, likely due to old versions of the test libraries. I can try to look at this later, but I'll be AFK for a day or two due to travel.

cdepillabout commented 6 years ago

Some of the tests are failing because of the code including in this PR. Here's one example:

https://travis-ci.org/snoyberg/mono-traversable/jobs/317633763#L655

It looks like some of the other tests are failing for other reasons. Taking a quick look at them, they appear to be unrelated to this PR.

I'll fix the error above that is caused by this PR.

cdepillabout commented 6 years ago

Okay, I've fixed the travis builds that were failing because of this PR in commit 96d5c2c.

The rest of the failures seem to be caused by other reasons.

snoyberg commented 6 years ago

Thanks! I'll try to address the Travis failures myself, but you're correct that it's unrelated.