Adding Mono* instances for GHC.Generics types and Data.Proxy.

snoyberg / mono-traversable

Type classes for mapping, folding, and traversing monomorphic containers

152 stars 61 forks source link

Adding Mono* instances for GHC.Generics types and Data.Proxy. #175

Closed recursion-ninja closed 5 years ago

recursion-ninja commented 5 years ago

The Data.MonoTraversable module is missing the Mono* instances for the relevant types from the GHC.Generics and Data.Proxy modules. It would be convenient to use these in a function which accepts a MonoTraversable input. Since the all the types for which instances were added have been included in base for the last several versions, this pull request should be a pretty simple and safe addition.

snoyberg commented 5 years ago

Thanks! Please add:

A minor version bump in the package.yaml (to version 1.0.11.0)
A comment to the ChangeLog
A @since Haddock comment on each new instance

recursion-ninja commented 5 years ago

@snoyberg I've added the request infrastructure updates.