search

snoyberg / mono-traversable

Type classes for mapping, folding, and traversing monomorphic containers
152 stars 61 forks source link

Fix building with time>=1.10 #207

Closed TeofilC closed 2 years ago

TeofilC commented 2 years ago

Thanks to @ocharles for spotting this issue.

I've added the extra imports required to make this build, and bumped the version. I used qualified imports to avoid more of Data.Time being re-exported

snoyberg commented 2 years ago

Would it be possible to add an additional stack.yaml that has a time in extra-deps that demonstrates the patch is working?

TeofilC commented 2 years ago

I've added a stack yaml that should allow testing newer versions of time. I picked time-1.10 as it seems to be the only version that has this change and is both compatible with lts-16 and lts-18. The rest of the extra-deps were recommended by stack. I'm not sure if they can be avoided.

I've also added this new stack yaml to the Github action's matrix.

TeofilC commented 2 years ago

Alright appears like lts-16 and time-1.10 are not compatible unfortunately, so I've excluded that combination. (It appeared fine locally as I had system-ghc: true set and was using 8.10)

TeofilC commented 2 years ago

It looks like one of the windows failures is due to https://github.com/jacobstanley/unix-compat/pull/47

snoyberg commented 2 years ago

I'd recommend simply skipping the time 1.10 build on Windows.

TeofilC commented 2 years ago

Sounds good. I've removed that job

snoyberg commented 2 years ago

Thanks!

ocharles commented 2 years ago

Thanks both, this is now working on GHC 9.2 :+1: