snoyberg / mono-traversable

Type classes for mapping, folding, and traversing monomorphic containers
153 stars 63 forks source link

Require pull request reviews before merging #228

Open BebeSparkelSparkel opened 1 month ago

BebeSparkelSparkel commented 1 month ago

@andreasabel @gregwebs @kbillings @maxcan @MaxGabriel

Are any of you still interested and have time to review/approve pull requests?

If so, what do you think about implementing required pull request views before merging?

andreasabel commented 1 month ago

@BebeSparkelSparkel I am just a one-shot contributor to this package (in Sep 2021), having done some simple maintenance that does not requires to understand the inner workings of this package. So, please do not consider me as reviewer for this package. But thanks for asking!

BebeSparkelSparkel commented 1 month ago

@andreasabel Thanks for letting me know!

gregwebs commented 1 month ago

@BebeSparkelSparkel are you interested in becoming a maintainer?

BebeSparkelSparkel commented 1 month ago

I use this a lot so yes

gregwebs commented 1 month ago

@snoyberg can you work out a transition. Do you want to add @BebeSparkelSparkel as a maintainer?

BebeSparkelSparkel commented 1 month ago

@gregwebs I already have write permissions. Do I need any others?

gregwebs commented 1 month ago

write on Github? Then there's the issue of releasing versions to Hackage

BebeSparkelSparkel commented 1 month ago

Good point about hackage.

snoyberg commented 1 month ago

@BebeSparkelSparkel if you send me your Hackage username and which packages you'd like to maintain there, happy to add you.