search

snoyberg / mono-traversable

Type classes for mapping, folding, and traversing monomorphic containers
153 stars 64 forks source link

Improve Data.MinLen documentation #66

Closed kbillings closed 9 years ago

snoyberg commented 9 years ago

@MaxGabriel If I'm not mistaken, you recently worked on this documentation, correct?

MaxGabriel commented 9 years ago

Yeah, these changes look good to me.

MaxGabriel commented 9 years ago

Not sure what others think about this, but do you feel like the emphasis on safe improves the documentation? It seems safe is a reasonable default, especially for this module, and possibly steals attention from the other two bolded things (Unsafe and function names).

Here's a comparison:

gregwebs commented 9 years ago

I do agree that in Haskell every function should be assumed safe by default.

kbillings commented 9 years ago

Ok I'll remove the emphasis on the safe functions.