search

snoyberg / mono-traversable

Type classes for mapping, folding, and traversing monomorphic containers
153 stars 63 forks source link

Would you care for a PR to do with fixing compiler warnings/HLint warnings in the codebase? #88

Open kozross opened 8 years ago

kozross commented 8 years ago

I personally like code which doesn't spew linter or compiler warnings, particularly with regard to deprecated constructs (as is currently the case). Would you be OK with a PR to this effect (or more exactly, would you consider merging such a PR as such)? It seems better to ask before undertaking this.

snoyberg commented 8 years ago

There are three concerns with these kinds of changes:

I'm not opposed to a PR, but especially the first point needs to be checked for.

On Sat, Jan 30, 2016, 2:53 AM Koz Ross notifications@github.com wrote:

I personally like code which doesn't spew linter or compiler warnings on construction, particularly with regard to deprecated constructs (as is currently the case). Would you be OK with a PR to this effect (or more exactly, would you consider merging such a PR as such)? It seems better to ask before undertaking this.

— Reply to this email directly or view it on GitHub https://github.com/snoyberg/mono-traversable/issues/88.

kozross commented 8 years ago

How would I check for the first point? Sorry if this seems like a dumb question - I've never had to worry about this before. Also, how many different versions of GHC and libraries do we have to stay compatible with - a lot of the compiler warnings I saw were deprecation-related, hence my question.

snoyberg commented 8 years ago

We typically target three versions of GHC, and try to keep compatibility with all versions of libraries as listed in the .cabal files. I personally don't find the trade-off worthwhile, since there's a lot of effort and uncertainty in removing all warnings, and not a lot of benefit.

On Sun, Jan 31, 2016 at 11:46 PM, Koz Ross notifications@github.com wrote:

How would I check for the first point? Sorry if this seems like a dumb question - I've never had to worry about this before. Also, how many different versions of GHC and libraries do we have to stay compatible with

  • a lot of the compiler warnings I saw were deprecation-related, hence my question.

— Reply to this email directly or view it on GitHub https://github.com/snoyberg/mono-traversable/issues/88#issuecomment-177623453 .

snoyberg commented 8 years ago

At this point, updated response: as long as the changes do not break the Travis build, they're safe to move ahead with.