Closed hvr closed 8 years ago
Indeed the severity of this is arguable. If someone feels strongly one way or another please open a ticket so we can discuss it.
Thanks for the report! I am fine with this being an error because there is no reason not to fix it. On the other hand, we would get about the same benefit from it being a warning and that would help with not breaking existing code.
@gregwebs fwiw, I just realised that all GHCs dating back to at least GHC 7.0 throw an error for spurious INLINE pragmas. It just turns out that GHCs prior to GHC 8 failed to detect these specific cases of detached INLINEs.
Thanks for the report, and this change looks good. I've removed the pragmas listed in your error message. Would you mind testing from HEAD before I release?
@snoyberg it looks like there are more such INLINE
s in Data.Sequences
.
OK, I actually got set up locally with GHC 8 and got this tested myself. This seems to be working correctly now, and I've released to Hackage. Thanks again for the report!
While it can be argued whether this should be an error or a warning (@bgamari ping?), the code seems in fact to contain
INLINE
pragmas which are misplaced... :-)