snoyberg / tar-conduit

Conduit based tar extraction mechanism
MIT License
8 stars 9 forks source link

Documenting the module a bit. #3

Closed bartavelle closed 7 years ago

bartavelle commented 7 years ago

I tried documenting the module a little bit, including an usage example.

I also tried highlighting the bad practice of collecting all file content before processing it.

Do you have suggestions about the content of this commit ? I will start publishing the package as soon as this is merged.

snoyberg commented 7 years ago

Signing off for the weekend, I'll review next week. Looking forward to it 👍

bartavelle commented 7 years ago

I changed the commit, taking into account your remarks. Thanks for the review!

snoyberg commented 7 years ago

Looking good!