search

snoyberg / tar-conduit

Conduit based tar extraction mechanism
MIT License
8 stars 9 forks source link

Allow checksums to have leading spaces #8

Closed meteficha closed 7 years ago

meteficha commented 7 years ago

It seems to me that leading spaces are a non-standard feature, but one that is seen in the wild. In particular the tar library already handles this case: https://github.com/haskell/tar/commit/455a26e3b3771c560555ad915a4e3d9b1c4d9a13.

I've hit this bug while trying to parse a tarball that looked fine otherwise. With this patch, it seems to work great!

bartavelle commented 7 years ago

Looks good to me. What creates those spaces?

meteficha commented 7 years ago

I'm not sure, to be honest, because I hadn't created the tarballs that exposed this issue. I can try to track it down if that is important.

bartavelle commented 7 years ago

That was just to satisfy my curiosity!

bartavelle commented 7 years ago

This is now published as v0.1.1

meteficha commented 7 years ago

Thanks! :)