snoyberg / xml

Various XML utility packages for Haskell
71 stars 64 forks source link

Expose currently hidden isWhitespace from xml-conduit #149

Open tolysz opened 4 years ago

tolysz commented 4 years ago

This function is useful outside the module itself. It would be beneficial to expose it.

k0ral commented 4 years ago

One of the builds fails, for some unrelated reason. I'll have a look at it.

k0ral commented 4 years ago

CI build should be fixed now, but your change must be rebased first.

Also, now that I think about it, I am not in favor of exporting isWhitespace as is, for the following reasons:

IMHO, this is one of the very few cases where duplicating the function in your project is a better tradeoff.