More accurate handling of DOCTYPE contents.

snoyberg / xml

Various XML utility packages for Haskell

71 stars 64 forks source link

More accurate handling of DOCTYPE contents. #160

Closed jgm closed 3 years ago

jgm commented 3 years ago

This should allow us to skip over <!ELEMENT, <!NOTATION, processing instructions, and other things that can be found inside DOCTYPE. This will avoid problems similar to the problem with comments in #157, since these elements might contain a ] character too.

k0ral commented 3 years ago

Looks good to me, but could you please just add a unit test that covers the new code ?

jgm commented 3 years ago

Sure, added some tests.

k0ral commented 3 years ago

Squashed and merged, thank you !