snozbot / fungus

An easy to use Unity 3D library for creating illustrated Interactive Fiction games and more.
MIT License
1.59k stars 291 forks source link

Refactoring Save Slot Controllers to work more with Save Slot Views #1014

Open CG-Tespy opened 3 years ago

CG-Tespy commented 3 years ago

Description

It's a refactor.

I've noticed that the source for the new SaveSlotController class has yet to be fully adapted to the new SlotView system. I figured I might as well take a crack at making it so, even writing unit tests to make sure things are as intended. At the time of this writing, I've only managed to confirm that the slots do indeed have their base views registered as intended.

Later on, I'd like to make changes such as removing the old nameText, descText, and timeStampText fields; the new view system renders them unnecessary.

I hope to later on also help clean up other UI-related parts of the save system, though that's for another time.

Important Notes

CG-Tespy commented 2 years ago

@stevehalliwell Finished. Removed some legacy fields and added tests to ensure that the slots do their thing right on their own. I've added to the view classes as well, based on the things the unit tests needed to check for.