search

snozbot / fungus

An easy to use Unity 3D library for creating illustrated Interactive Fiction games and more.
MIT License
1.62k stars 290 forks source link

Voice Over Localization #376

Open StefanoCecere opened 8 years ago

StefanoCecere commented 8 years ago

i could not find any info about the localization of the VoiceOver (it's still an hardcoded audio clip into the Say action)

is it possibile anyway or a new (possibile) feature?

StefanoCecere commented 8 years ago

since i work with Fabric Audio Engine and developing basic commands to integrate Fabric into Fungus

and Fabric provide a perfect Dialog compoinent to multilanguage translated sentences.. i think the best would be to add an optional "Fabric string ID" to the Say component.. so to let Fabric do the Voice Over automatically choosing the audio language

would it be possibile to extend the Say command with an external class?

chrisgregan commented 8 years ago

Hey Stefano,

The simplest thing I can think of here would be to make a PlayFabicAudio custom command which you call just before each Say command. That should be equivalent to having the Say command do it?

If you do want to customise Fungus to manage a Fabric string id, you would need to modify Say.cs to add the string property, and SayEditor.cs to display the property for editing in the custom inspector. You could modify the Say.OnEnter() method to tell Fabric to play the required audio clip when a Fabric String ID is present.

As Fabric is a commercial library that most of our users wouldn't have available, it's probably not a good idea to add this as a standard feature in Fungus.

StefanoCecere commented 8 years ago

Hi @chrisgregan yes i already tried modifying Say.cs and it works nicely.. i was just wandering if it was possibile to "extend" it without touching the original class

no i don't want to duplicate the Say command (i have hundreds of say blocks already :(

well to tell the truth, Fabric is free for project <150K budget, that's why i use it a lot (and prefer to many other engine.. commercial or opensource)

maybe i can publish the modified Say.cs somewhere?

thank you!

PS: i used Fungus all weekend for GGJ16 ;)

chrisgregan commented 8 years ago

Cool - feel free to post your solution on the forums, might be useful to other folks!

Glad to hear you used Fungus for GGJ, did you get your game completed in the end?

Chris

On Mon, Feb 1, 2016 at 3:54 PM, Stefano Cecere notifications@github.com wrote:

Hi @chrisgregan https://github.com/chrisgregan yes i already tried modifying Say.cs and it works nicely

well to tell the truth, Fabric is free for project <150K budget, that's why i use it a lot (and prefer to many other engine.. commercial or opensource)

maybe i can publish the modified Say.cs somewhere?

thank you!

PS: i used Fungus all weekend for GGJ16 ;)

— Reply to this email directly or view it on GitHub https://github.com/FungusGames/Fungus/issues/376#issuecomment-178039659.

StefanoCecere commented 8 years ago

sure! well it's missing 50% on english labels.. but i'm working on it! and we couldn't make voiceover (it was me and my young son).. but we had great fun and Fungus was perfect for his story!

http://globalgamejam.org/2016/games/im-not-just-sheep-non-sono-solo-una-pecora

or https://github.com/JAMURR/JAM.NotJustASheep ;)

chrisgregan commented 8 years ago

Ah that's awesome! Well done to you and your son. I'll add this the Fungus website soon :)

Chris

On Mon, Feb 1, 2016 at 4:52 PM, Stefano Cecere notifications@github.com wrote:

sure! well it's missing 50% on english labels.. but i'm working on it! and we couldn't make voiceover (it was me and my young son).. but we had great fun and Fungus was perfect for his story!

http://globalgamejam.org/2016/games/im-not-just-sheep-non-sono-solo-una-pecora

— Reply to this email directly or view it on GitHub https://github.com/FungusGames/Fungus/issues/376#issuecomment-178064552.