snozbot / fungus

An easy to use Unity 3D library for creating illustrated Interactive Fiction games and more.
MIT License
1.64k stars 290 forks source link

Using conversation tags to change portrait is failing #827

Open ianicmathieu opened 4 years ago

ianicmathieu commented 4 years ago

Describe the bug when using conversation tags to change the portrait is failing in some cases. Otis : Hi Lottie unsure : Hello Otis : how are you. Lottie : fine.

in a simple case like this, sometimes when Lottie says "fine" the portrait "unsure" is present. Sometimes it's not.

It appears random, but in a long conversation it appears constantly.

To Reproduce

Create a scene using Conversations and conversation tags to change portraits.

Versions & Platform (please complete the following information):

stevehalliwell commented 4 years ago

I've generated a test conversation and it doesn't appear to have the issue as described. If you are able please provide additional information about the situation and cause. If you are able to create a convo with john and sherlock from the examples that demonstrates the bug that would be ideal.

Convo I generated and tested below;

john angry left: Ready?
sherlock angry right: Ready.
sherlock angry:angry
sherlock annoyed:annoyed
sherlock bored:bored
sherlock calling-neutral:calling-neutral
sherlock concentrating:concentrating
sherlock confident:confident
sherlock coughing:coughing
sherlock deduction:deduction
sherlock disgusted:disgusted
sherlock excited:excited
sherlock explaining:explaining
sherlock eyeroll:eyeroll
sherlock happy:happy
sherlock ill:ill
sherlock laughing:laughing
sherlock neutral:neutral
sherlock neutral2:neutral2
sherlock pleased:pleased
sherlock regretful:regretful
sherlock sad:sad
sherlock sarcastic:sarcastic
sherlock scared:scared
sherlock serious:serious
sherlock sherlock_neutral:sherlock_neutral
sherlock shocked:shocked
sherlock smirk:smirk
sherlock sorry:sorry
sherlock surprised:surprised
sherlock suspicious:suspicious
sherlock texting:texting
sherlock thinking:thinking
sherlock tired:tired
sherlock triumphant:triumphant
john angry:angry
john annoyed:annoyed
john apologetic:apologetic
john bored:bored
john calling-neutral:calling-neutral
john concentrating:concentrating
john confident:confident
john confused:confused
john eyeroll:eyeroll
john frustrated:frustrated
john laughing:laughing
john neutral:neutral
john neutral2:neutral2
john pained:pained
john pleased:pleased
john regretful:regretful
john sad:sad
john sarcastic:sarcastic
john scared:scared
john serious:serious
john shocked:shocked
john smirk:smirk
john sorry:sorry
john sulking:sulking
john surprised:surprised
john suspicious:suspicious
john tired:tired
john triumphant:triumphant
john worried:worried
ianicmathieu commented 4 years ago

I understand it can be difficult to pinpoint - I am having the same problem.

Here is my node + the conversation script.

I played the section three times and got the face to "disappear" at three different times. Maybe you can see something I do not.

image

Henri : Did someone say my name? Elsa : Henri, this is Lottie. {wc} She came in for the internship. Henri c_cold : Oh.{wc} I see. Lottie normal : Nice to meet you, Mr. Heikki. Henri : This is awkward. Lottie unsure : Awkward? Elsa : Very Awkward. Henri : No matter, I’ll handle it.{wc}Did you just arrive in the city? Lottie : I arrived yesterday. {wc} What do you mean...{i}awkward.{/i}? NO MORE FACE SOMETIMES HERE. <<---- Henri : Uh, may I call you Lottie? Lottie : Sure. Henri c_unhappy : Lottie, I won’t drag this conversation longer than it needs to be. {wc} You were contacted by my father, not me.{wc} And when Mr. Heikki, senior, offered you an internship, he should’ve spoken with me.{wc} You see, I promised the internship to Elsa here months ago. Lottie sad : Oh. Elsa : Indeed. Henri c_smile : So, as you can see, the position has been filled. Elsa : I’m very sorry for you. {wc} Now you understand why this is a bit… {i}awkward.{/i} Lottie arguing : You mean, I can’t work here? Henri c_cold : The position has been filled. Lottie unsure : But Mr. Heikki already hired me. NO MORE FACE SOMETIMES HERE. <<---- Henri : He offered you an internship. {wc}An internship that is no longer available. {wc} I’m very sorry you came all this way for nothing. Lottie arguing : Could I speak with your father? Henri c_unhappy : What? No! {wc} You can’t speak with my father. { wc} This matter is resolved. {wc} I am truly sorry about this situation.{wc} Someone should’ve contacted you. Lottie disapointed : I came by train and... Henri c_smile : We can offer you a ticket back home. {wc} Elsa, can you make the arrangements? Elsa : Absolutely. Lottie yelling : No! Lottie disapointed : I’m sorry.{wc} I don’t want to go back home.{wc}I want the internship that was promised to me! NO MORE FACE SOMETIMES HERE. <<---- Elsa : Oh my. {wc} I think I’d better go.

stevehalliwell commented 4 years ago

Is it always the same character having issues for you? If it's happening in editor, can you pause the game when it happens and determine if the portraits are on stage but not active/enabled or alpha zero, or not at the correct stage position etc.

ianicmathieu commented 4 years ago

image

good idea. So it appears the TAG is not working. As we see in the screenshot - none of the faces expressions are shown. ( all remain hidden )

I played the same sequence again, this time I waited for each line to be 100% completed before skipping to the next line and every face were shown properly.

I believe the issue might be related skipping a Conversation line. I tried with ESC, spacebar and mouse click and all made the TAG not work at some point

stevehalliwell commented 4 years ago

I updated my test conversation to include tag usage like the lines with which you are having issues. Still functioning as expected on my end, both when letting lines write and when skipping through. If you have any additional details or are able to recreate the issue using FungusExample assets, that may help identify the cause.

john neutral left: Ready?
sherlock bored right : I have some other things to do
john annoyed : But {wc}the face off?
sherlock explaining : To see if this causes any {wc} issues.
sherlock serious : Now{wc} for some {b}test phrases{/b}...
sherlock regretful : Including waits. {wc} and use of tags...{i}italics!{/i}?
sherlock angry right: Ready.
ianicmathieu commented 4 years ago

This worked fine in a previous Fungus build. ( the Project I am testing with has already been released on PC and doesn't have the issue. ) I can send over the complete project if this help you investigate.