snozbot / fungus

An easy to use Unity 3D library for creating illustrated Interactive Fiction games and more.
MIT License
1.63k stars 290 forks source link

LoadSceneMode.Additive not working with Fungus Save Menu 'Load on start' option #956

Open trajkd opened 3 years ago

trajkd commented 3 years ago

Describe the bug When I tell to load a scene additively with Fungus Save Menu in it with the ‘Load on start’ option enabled, the previous scene gets removed anyways.

To Reproduce

  1. Make two scenes.
  2. Make the first scene load the second scene additively with LoadSceneMode.Additive e.g. by clicking on a button on the first scene.
  3. The second scene should have a Fungus Save Menu in it with the ‘Load on start’ option enabled.
  4. Note that the first scene gets destroyed anyways.

Expected behavior The scene with Fungus shouldn't close the previous scene when loaded.

Versions & Platform

Additional context These lines inside SaveManager.cs are causing the issue:

// Ignore additive scene loads
if (mode == LoadSceneMode.Additive)
{
    return;
}
stevehalliwell commented 3 years ago

Pre 3.14 Fungus doesn't have any support for addative loading. Adding 3.13 milestone here to ensure it is reviewed and handled or configurable.