JSONChecker.cs uses deprecated code.

snozbot / fungus

An easy to use Unity 3D library for creating illustrated Interactive Fiction games and more.

MIT License

1.6k stars 291 forks source link

JSONChecker.cs uses deprecated code. #961

Open ianicmathieu opened 3 years ago

ianicmathieu commented 3 years ago

Describe the bug Assets\Fungus\Thirdparty\FungusLua\Thirdparty\JSON\Editor\JSONChecker.cs(76,28): warning CS0618: 'UnityWebRequest.isNetworkError' is obsolete: 'UnityWebRequest.isNetworkError is deprecated. Use (UnityWebRequest.result == UnityWebRequest.Result.ConnectionError) instead.'

Not exactly sure why this is popping up in 2020 LTS but in my project, I have this warning.

Looks like some code needs to be updated.

ianicmathieu commented 3 years ago

while (!test.isDone && test.result == UnityWebRequest.Result.ConnectionError); (edited)

The fix appear to be change the unitywebrequest line to this.

stevehalliwell commented 3 years ago

Just from the file path, seems to come from a thirdparty dep. So we'll either check there for updates or consider bringing it out into our own fork, if the license allows.