search

snozbot / fungus

An easy to use Unity 3D library for creating illustrated Interactive Fiction games and more.
MIT License
1.59k stars 291 forks source link

Fix StackOverflow Exception When Skipping While Flash Still Active #988

Closed breadnone closed 3 years ago

breadnone commented 3 years ago

Description

When skipping dialogue while Flash still not done tweening, it will cause StackOverflow Exception

What is the current behavior?

Skipping dialogue will throw StackOverflow Exception while flash is not done tweening

What is the new behavior?

Will not re-instantiate tween if Flash is still active

Other information

Closes https://github.com/snozbot/fungus/issues/973

breadnone commented 3 years ago

This fix doesn't make any sense... It would just cause problems to anything related to stopping the fading prematurely.

Just don't set Cancel to enable. That feature doesn't make any sense on build

Closing this...