snp-technologies / lagoon

Docker Build and Deploy System for OpenShift & Kubernetes
Apache License 2.0
0 stars 0 forks source link

Replace services.yml with Helm chart #1

Closed snpdev closed 5 years ago

snpdev commented 5 years ago

This is a sub-issue of https://github.com/amazeeio/lagoon/issues/564#issue-350184516, bullet 5:

  1. Create OpenShift objects (Services, Routes/Ingress, ConfigMaps) based on some given data within .lagoon.yml (happens in https://github.com/amazeeio/lagoon/blob/master/images/oc-build-deploy-dind/build-deploy-docker-compose.sh#L174-L304)

This issue specifically concerns the replacement of the Services OpenShift Template with a Helm chart.

OPENSHIFT_SERVICES_TEMPLATE="/oc-build-deploy/openshift-templates/${SERVICE_TYPE}/services.yml"
  if [ -f $OPENSHIFT_SERVICES_TEMPLATE ]; then
    OPENSHIFT_TEMPLATE=$OPENSHIFT_SERVICES_TEMPLATE
    .  /oc-build-deploy/scripts/exec-openshift-resources.sh
fi

https://github.com/amazeeio/lagoon/blob/master/images/oc-build-deploy-dind/build-deploy-docker-compose.sh#L241-L245

snpdev commented 5 years ago

Closing. We are not creating a Helm chart for each K8s resource. Rather, we will have a Helm chart for each service, e.g. Varnish.