Helm chart for Varnish image deployment

[snpdev]

This is a sub-issue of https://github.com/amazeeio/lagoon/issues/564#issue-350184516, bullet 7:

7. Create more OpenShift Objects (Deployments, PVCs) based on the figured out services (happens in https://github.com/amazeeio/lagoon/blob/master/images/oc-build-deploy-dind/build-deploy-docker-compose.sh#L365-L495)

This issue specifically concerns the integration of Helm chart to deploy the Varnish image defined in https://github.com/snp-technologies/lagoon/tree/master/images/varnish.

[snpdev]

Here is we where we stand today. To the helm-integration branch, @siva2krish has committed:

• https://github.com/snp-technologies/lagoon/commit/6a055cb5e9a1e092fb9294a623ed057087826fe2 : A Varnish Helm chart at images/oc-build-deploy-dind/helm-charts/varnish/ please ignore the cruft in this commit, e.g. mySettingsDemo, it is cleaned up in commit https://github.com/snp-technologies/lagoon/commit/31a81ee0d452ff9afd4a8cfb98a3cfda370fb1c4.

• Tidying up in https://github.com/snp-technologies/lagoon/commit/31a81ee0d452ff9afd4a8cfb98a3cfda370fb1c4, https://github.com/snp-technologies/lagoon/commit/869957f8906febc91e972326b582b08d8380de34, and https://github.com/snp-technologies/lagoon/commit/9dbe33207bf75c7e65693b28dc3ca4db06f908f7

• https://github.com/snp-technologies/lagoon/commit/2f0784b2f5742f026f1f0fa3411dc638facd975c : Here we:

  1. Add a line to COPY helm-charts /oc-build-deploy/helm-charts in images/oc-build-deploy-dind/Dockerfile
  2. Add scripting in images/oc-build-deploy-dind/build-deploy-docker-compose.sh to install the Helm client binary, and run helm install to deploy the Varnish image.

You will notice that the Varnish image and tag variables are hard-coded, i.e. --set image.repository=dockerimages/docker-varnish --set image.tag=latest

Determination of the SERVICE_IMAGE value is not 100% clear to us, though it looks like https://github.com/snp-technologies/lagoon/blob/master/images/oc-build-deploy-dind/scripts/exec-openshift-resources-with-images.sh#L27-L29 holds the key.

[snpdev]

@Schnitzel;

@siva2krish pushed a new commit today, https://github.com/snp-technologies/lagoon/commit/43d7772d494f0305b5af7ed0ee01b46f4d1fc8a9.

Note:

• Permissions update to the Helm client installation
• Better conforming to Lagoon coding standards
• helm install now parameterized
• We left in a break at line 690, in place for testing.

Please review and then we can discuss next steps.

Thanks - Mike