snp-technologies / lagoon

Docker Build and Deploy System for OpenShift & Kubernetes
Apache License 2.0
0 stars 0 forks source link

Replace deployment.yml with Helm chart #7

Closed snpdev closed 5 years ago

snpdev commented 5 years ago

This is a sub-issue of https://github.com/amazeeio/lagoon/issues/564#issue-350184516, bullet 7:

  1. Create more OpenShift Objects (Deployments, PVCs) based on the figured out services (happens in https://github.com/amazeeio/lagoon/blob/master/images/oc-build-deploy-dind/build-deploy-docker-compose.sh#L365-L495)

This issue specifically concerns the replacement of the Deployment OpenShift Template with a Helm chart.

# Generate deployment if service type defines it
    OPENSHIFT_DEPLOYMENT_TEMPLATE="/oc-build-deploy/openshift-templates/${SERVICE_TYPE}/deployment.yml"
    if [ -f $OPENSHIFT_DEPLOYMENT_TEMPLATE ]; then
      OPENSHIFT_TEMPLATE=$OPENSHIFT_DEPLOYMENT_TEMPLATE
      . /oc-build-deploy/scripts/exec-openshift-resources-with-images.sh
fi

https://github.com/amazeeio/lagoon/blob/master/images/oc-build-deploy-dind/build-deploy-docker-compose.sh#L587-L592

snpdev commented 5 years ago

Closing. We are not creating a Helm chart for each K8s resource. Rather, we will have a Helm chart for each service, e.g. Varnish.