search

sns-sdks / python-facebook

A simple Python wrapper for facebook graph api :sparkles: :cake: :sparkles: .
https://sns-sdks.github.io/python-facebook/
322 stars 84 forks source link

User likes get endpoint dev #214

Closed kamau-edwin closed 1 year ago

kamau-edwin commented 1 year ago

Hello Thank you for developing the Facebook SDK its very well written and easy to use. Meanwhile, I needed the functionality for my application to also get public profile endpoints(birthday, age_range, location, hometown, gender, link, ..). Additionally, user_likes. To do so I have added some functionality on version 0.15.0 (one that is still in development) to exclusively collect data from these endpoints. I have also updated the Readme.rst for the functionality added. I have tested the added functionality(python 3.9 only) and using the functionality in production I would appreciate if you reviewed it and additionally included them in your next pypi submission

MerleLiuKun commented 1 year ago

wow, thanks for your work, I will take a look for this, may need some time :)

kamau-edwin commented 1 year ago

Thanks for testing. Is there anything I need to do for the failed test

MerleLiuKun commented 1 year ago

could you use black to format the code? :)

kamau-edwin commented 1 year ago

Thank you for the response. I re-formatted the modified files python files using black see commit [7eacdbf]

MerleLiuKun commented 1 year ago

Sorry for late reply, I have left some comment, May need you to take a look.

kamau-edwin commented 1 year ago

Hi Merle. I do not see your comments in the PR

MerleLiuKun commented 1 year ago

I have mentioned you, just to see the review.

MerleLiuKun commented 1 year ago

Hi, @kamau-edwin there still in progress?

kamau-edwin commented 1 year ago

Hi! I do not understand what you mean with still in progress! I have been using the modified version to pull data and have not encountered any glaring errors

MerleLiuKun commented 1 year ago

hi, have you saw this?

image image

I have some comments for your pr.

kamau-edwin commented 1 year ago

Hello MerleLiu! I added the likes edge to the feed and user ignorer to keep them on the same purview as the get_posts that way I can use the user node and reach both likes and post edges.
Its true the get_endpoint is redundant but I wanted to specify the public profile endpoint that I need instead of getting the entire pay load from that endpoint. That way I only get the data my user have provided permission for a particular public profile endpoint.

kamau-edwin commented 1 year ago

Please let me know the status of this PR as well

MerleLiuKun commented 1 year ago

Very thanks for your PR, And i have a new impl for this.